[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 07/14] qapi: Drop redundant, unclean error_is_set
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 07/14] qapi: Drop redundant, unclean error_is_set() |
Date: |
Fri, 2 May 2014 13:26:35 +0200 |
do_qmp_dispatch()'s test for qmp_dispatch_check_obj() failure examines
both the return value and the error object. The latter part is
unclean; it works only when do_qmp_dispatch()'s caller passes a
non-null errp argument. That's the case, but it's not locally
obvious. Unclean.
Cleanup would be easy enough, but since the unclean code is also
redundant, let's just drop it.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
---
qapi/qmp-dispatch.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 141a376..187af56 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -67,9 +67,8 @@ static QObject *do_qmp_dispatch(QObject *request, Error
**errp)
QmpCommand *cmd;
QObject *ret = NULL;
-
dict = qmp_dispatch_check_obj(request, errp);
- if (!dict || error_is_set(errp)) {
+ if (!dict) {
return NULL;
}
--
1.8.1.4
- [Qemu-devel] [PATCH v3 03/14] qmp: Consistently name Error ** objects errp, and not err, (continued)
- [Qemu-devel] [PATCH v3 03/14] qmp: Consistently name Error ** objects errp, and not err, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 04/14] error: Consistently name Error ** objects errp, and not err, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 12/14] qemu-option: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 10/14] qga: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 14/14] qmp: Don't use error_is_set() to suppress additional errors, Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 02/14] qga: Consistently name Error ** objects errp, and not err, Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 07/14] qapi: Drop redundant, unclean error_is_set(),
Markus Armbruster <=
[Qemu-devel] [PATCH v3 08/14] tests/qapi-schema: Drop superfluous error_is_set(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 13/14] dump: Drop pointless error_is_set(), DumpState member errp, Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 09/14] qapi: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 06/14] hmp: Guard against misuse of hmp_handle_error(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 11/14] qga: Drop superfluous error_is_set(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 01/14] qmp hmp: Consistently name Error * objects err, and not errp, Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 05/14] qga: Use return values instead of error_is_set(errp), Markus Armbruster, 2014/05/02
Re: [Qemu-devel] [PATCH v3 00/14] qmp qga: Purge error_is_set(), Eric Blake, 2014/05/02
Re: [Qemu-devel] [PATCH v3 00/14] qmp qga: Purge error_is_set(), Luiz Capitulino, 2014/05/07