[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks gen
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic |
Date: |
Tue, 29 Apr 2014 10:25:54 +0300 |
On Tue, Apr 29, 2014 at 10:12:34AM +0200, Paolo Bonzini wrote:
> Il 07/04/2014 17:36, Michael S. Tsirkin ha scritto:
> >>> * What if there would be more handlers that could or should handle event
> >>> for device?
> >That's actually very useful. We could scan top to bottom
> >so e.g. acpi can intercept bridges.
> >
>
> Be careful about "top to bottom". Does top-to-bottom mean by bus or
> by composition? This has been a huge can of worms in the
> discussions about recursive realization.
>
> One thing we could do is to always go through /machine even before
> invoking the bus handler. Then /machine can do machine-specific
> checks to interpose the PCI host bridge and/or the ACPI device's
> hotplug handlers.
>
> But this can be done on top of this series, it has nothing to do
> with memory hotplug and this one is already big enough!
>
> Paolo
Yes, new functionality does not need to be added in this patchset.
But to repeat what I was saying, this check (that object passed in
is a PCI DEVICE) belongs in acpi_pcihp_device_plug_cb and should not be
piix specific, I don't want to duplicate this logic in q35 later.
Similar checks should be added in
shpc_device_hotplug_cb pcie_cap_slot_hotplug_cb for consistency.
--
MST
- [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, (continued)
- [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Igor Mammedov, 2014/04/04
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Michael S. Tsirkin, 2014/04/07
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Igor Mammedov, 2014/04/07
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Michael S. Tsirkin, 2014/04/07
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Igor Mammedov, 2014/04/07
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Michael S. Tsirkin, 2014/04/07
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Igor Mammedov, 2014/04/07
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Michael S. Tsirkin, 2014/04/07
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Igor Mammedov, 2014/04/11
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Paolo Bonzini, 2014/04/29
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Paolo Bonzini, 2014/04/29
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Michael S. Tsirkin, 2014/04/29
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Paolo Bonzini, 2014/04/29
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Michael S. Tsirkin, 2014/04/07
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Paolo Bonzini, 2014/04/11
- Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic, Michael S. Tsirkin, 2014/04/29
[Qemu-devel] [PATCH 22/35] trace: add DIMM slot & address allocation for target-i386, Igor Mammedov, 2014/04/04
[Qemu-devel] [PATCH 25/35] pc: ich9 lpc: make it work with global/compat properties, Igor Mammedov, 2014/04/04
[Qemu-devel] [PATCH 16/35] pc: add memory hotplug handler to PC_MACHINE, Igor Mammedov, 2014/04/04
[Qemu-devel] [PATCH 27/35] pc: migrate piix4 & ich9 MemHotplugState, Igor Mammedov, 2014/04/04