qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks gen


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic
Date: Fri, 11 Apr 2014 21:40:19 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

Il 07/04/2014 11:19, Michael S. Tsirkin ha scritto:
This means we can't cleanly implement an option for guest to
disable ACPI and switch to native if supported,
like the ACPI spec allows.

If we change hotplug code to walk the tree top down
and invoke all callbacks, then it will be fixed
in a cleaner way: bridges would just do:

        if (dev->bus != self) {
                set_error
                return;
        }

and suddently pci host can trap callbacks and redirect
to acpi if it wants to.

I think this should be handled by making the q35 PCI host bridge implement HotplugHandler itself, possibly overriding the parent's implementation.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]