Re: [Qemu-devel] [PATCH 0/3] target-arm: support setend instruction

[Peter Maydell]

On 21 April 2014 21:52, Peter Maydell <address@hidden> wrote:
> I think we get the various neon load/store insns right, but did you
> check the pseudocode against our implementation or are you just
> hoping that we never try to combine or split a load/store compared
> to the pseudocode spec?

Thinking more about this, we'd be wrong already for bigendian
if these were wrong. The bit about the linux-user/main.c strex/ldrex
still stands, though, because those use get_user*/put_user* which
use the TARGET_BIGENDIAN specified endianness. The commpage
code may also need updating to correctly handle the effects of being
called with the wrong endianness (though we can probably get away
with declaring that to be lunacy and not well defined...)

[Tangentially: we really need a vdso for aarch64, at which point we
might as well do the aarch32 commpage with one too. IIRC RTH had
some patches for x86-64 vdso which I should fish out of the archives...]

thanks
-- PMM