Re: [Qemu-devel] [PATCH 2/3] target-arm: introduce be8 tbflag

[Peter Maydell]

On 21 April 2014 18:43, Paolo Bonzini <address@hidden> wrote:
> The tb flag for be8 mode comes from the CPSR E bit.  This will let us
> implement setend in the next patch.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  linux-user/main.c      |  1 +
>  target-arm/cpu.h       |  7 +++++++
>  target-arm/translate.c | 29 +++++++++++++++++++----------
>  target-arm/translate.h |  1 +
>  4 files changed, 28 insertions(+), 10 deletions(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index af924dc..d1e29bf 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -4200,6 +4200,7 @@ int main(int argc, char **argv, char **envp)
>          if (EF_ARM_EABI_VERSION(info->elf_flags) >= EF_ARM_EABI_VER4
>              && (info->elf_flags & EF_ARM_BE8)) {
>              env->bswap_code = 1;
> +            env->uncached_cpsr = CPSR_E;

We only want to OR in the E bit here, not clear everything
else too.

thanks
-- PMM