[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/4] qemu-img: Avoid duplicate block device I
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/4] qemu-img: Avoid duplicate block device IDs |
Date: |
Mon, 21 Apr 2014 08:59:52 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/17/2014 09:48 AM, Kevin Wolf wrote:
> qemu-img used to use "image" as ID for all block devices. This means
> that e.g. img_convert() ended up with potentially multiple source images
> and one target image, all with the same ID. The next patch will catch
> this and fail to open the block device.
>
> This patch makes sure that qemu-img uses meaningful unique IDs for the
> block devices it uses.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> qemu-img.c | 38 ++++++++++++++++++++++----------------
> 1 file changed, 22 insertions(+), 16 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature