Re: [Qemu-devel] [PATCH v2 1/4] block: Add errp to bdrv_new()

[Eric Blake]

On 04/17/2014 09:48 AM, Kevin Wolf wrote:
> This patch adds an errp parameter to bdrv_new() and updates all its
> callers. The next patches will make use of this in order to check for
> duplicate IDs. Most of the callers know that their ID is fine, so they
> can simply assert that there is no error.
> 
> Behaviour doesn't change with this patch yet as bdrv_new() doesn't
> actually assign errors to errp.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c               | 6 +++---
>  block/iscsi.c         | 2 +-
>  block/vvfat.c         | 2 +-
>  blockdev.c            | 9 +++++++--
>  hw/block/xen_disk.c   | 7 +++++--
>  include/block/block.h | 2 +-
>  qemu-img.c            | 6 +++---
>  qemu-io.c             | 2 +-
>  qemu-nbd.c            | 3 ++-
>  9 files changed, 24 insertions(+), 15 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature