[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_mi
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive) |
Date: |
Mon, 07 Apr 2014 14:21:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Peter Maydell <address@hidden> writes:
> On 7 April 2014 12:47, Juan Quintela <address@hidden> wrote:
>> Peter Maydell <address@hidden> wrote:
>>> I'm really not a fan of this kind of single patch that
>>> touches a huge number of files at once. They're basically
>>> impossible to review and they introduce the possibility
>>> of conflicts between submaintainer tree changes and the
>>> big patch. There's no reason to have all these changes
>>> in a single patch -- I'd much rather see one patch per
>>> subsystem sent to the relevant submaintainers, plus
>>> one for all the unmaintained stuff which can go via
>>> the migration tree.
>>
>> If you say how to split, I am all for it.
>
> Like I said, one patch per maintained subsystem,
> one patch for the leftovers.
Easier said than done. MAINTAINERS has more than 100 sections, yet it
leaves more than 1200 files uncovered, roughly half of them C sources.
I doubt splitting mechanically along those sections plus a catch-all
patch for the "unmaintained" files would be appreciated.
Could you give some guidance on splitting?
- [Qemu-devel] [PATCH 06/97] vmstate: Refactor & increase tests for primitive types, (continued)
- [Qemu-devel] [PATCH 06/97] vmstate: Refactor & increase tests for primitive types, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 08/97] vmstate: Remove VMSTATE_UINTL_EQUAL_V, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 09/97] vmstate: Change VMSTATE_INTTL_V to VMSTATE_INTTL_TEST, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 10/97] vmstate: Remove unused VMSTATE_UINTTL_ARRAY_V, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 11/97] vmstate: Test for VMSTATE_BOOL_TEST, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 12/97] vmstate: Test for VMSTATE_INT8_TEST, Juan Quintela, 2014/04/06
- [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive), Juan Quintela, 2014/04/06
[Qemu-devel] [PATCH 13/97] vmstate: Test for VMSTATE_INT16_TEST, Juan Quintela, 2014/04/06
[Qemu-devel] [PATCH 14/97] vmstate: Test for VMSTATE_INT32_TEST, Juan Quintela, 2014/04/06
[Qemu-devel] [PATCH 15/97] vmstate: test for VMSTATE_INT64_TEST, Juan Quintela, 2014/04/06
[Qemu-devel] [PATCH 16/97] vmstate: Test for VMSTATE_UINT8_TEST, Juan Quintela, 2014/04/06
[Qemu-devel] [PATCH 17/97] vmstate: Test for VMSTATE_UINT16_TEST, Juan Quintela, 2014/04/06
[Qemu-devel] [PATCH 19/97] vmstate: Test for VMSTATE_UINT64_TEST, Juan Quintela, 2014/04/06
[Qemu-devel] [PATCH 18/97] vmstate: Test for VMSTATE_UINT32_TEST, Juan Quintela, 2014/04/06