Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

[Peter Maydell]

On 7 April 2014 04:20, Juan Quintela <address@hidden> wrote:
> After previous Peter patch, they are redundant.  This way we don't asign them
> except when needed.  Once there, there were lots of case where the ".fields"
> indentation was wrong:
>
>      .fields = (VMStateField []) {
> and
>      .fields =      (VMStateField []) {
>
> Change all the combinations to:
>
>      .fields = (VMStateField[]){
>
> The biggest problem (appart of aesthetics) was that checkpatch complained
> when we copy&pasted the code from one place to another.
>
>  211 files changed, 289 insertions(+), 621 deletions(-)

I'm really not a fan of this kind of single patch that
touches a huge number of files at once. They're basically
impossible to review and they introduce the possibility
of conflicts between submaintainer tree changes and the
big patch. There's no reason to have all these changes
in a single patch -- I'd much rather see one patch per
subsystem sent to the relevant submaintainers, plus
one for all the unmaintained stuff which can go via
the migration tree.

thanks
-- PMM