[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mod
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode |
Date: |
Wed, 02 Apr 2014 17:19:51 +0200 |
On Mi, 2014-04-02 at 11:07 -0400, Cole Robinson wrote:
> + if (button->button == 1 &&
> + button->type == GDK_BUTTON_PRESS &&
> + !gd_is_grab_active(s) &&
> + !qemu_input_is_absolute()) {
> +
> gtk_check_menu_item_set_active(GTK_CHECK_MENU_ITEM(s->grab_item),
> + TRUE);
> + return TRUE;
> + }
Looks sane on a quick glance (as replacement for patch #4 of Takashi's
patch series). Didn't test yet.
cheers,
Gerd
- [Qemu-devel] [PATCH v2 0/4] Fix relative pointer tracking on Gtk UI (v2), Takashi Iwai, 2014/04/02
- [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option, Takashi Iwai, 2014/04/02
- Re: [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option, Cole Robinson, 2014/04/02
- Re: [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option, Gerd Hoffmann, 2014/04/02
- [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode, Cole Robinson, 2014/04/02
- Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode, Takashi Iwai, 2014/04/02
- Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode, Cole Robinson, 2014/04/02
- Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode, Takashi Iwai, 2014/04/03
[Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event, Takashi Iwai, 2014/04/02
[Qemu-devel] [PATCH v2 3/4] gtk: Remember the last grabbed pointer position, Takashi Iwai, 2014/04/02
[Qemu-devel] [PATCH v2 2/4] gtk: Fix the relative pointer tracking mode, Takashi Iwai, 2014/04/02