Re: [Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event

[Takashi Iwai]

At Wed, 02 Apr 2014 17:17:54 +0200,
Gerd Hoffmann wrote:
> 
> On Mi, 2014-04-02 at 14:32 +0200, Takashi Iwai wrote:
> > +static gboolean gd_event(GtkWidget *widget, GdkEvent *event, void
> > *opaque)
> > +{
> > +    if (event->type == GDK_MOTION_NOTIFY)
> > +        return gd_motion_event(widget, &event->motion, opaque);
> > +    return FALSE;
> > +}
> 
> Fails checkpatch:
> 
> WARNING: braces {} are necessary for all arms of this statement
> #12: FILE: ui/gtk.c:771:
> +    if (event->type == GDK_MOTION_NOTIFY)
> [...]
> 
> total: 0 errors, 1 warnings, 23 lines checked

OK, you guys have a different checkpatch bible than the kernel tree :)
I'll tidy up later, if the patch is really acceptable.


thanks,

Takashi