[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] hw/net/stellaris_enet: Correctly implement
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 4/5] hw/net/stellaris_enet: Correctly implement the TR and THR registers |
|
Date: |
Tue, 1 Apr 2014 19:08:03 +0100 |
On 1 April 2014 18:44, Dr. David Alan Gilbert <address@hidden> wrote:
> * Peter Maydell (address@hidden) wrote:
>
> <snip>
>
>> @@ -338,9 +347,11 @@ static void stellaris_enet_write(void *opaque, hwaddr
>> offset,
>> case 0x2c: /* MTXD */
>> s->mtxd = value & 0xff;
>> break;
>> + case 0x38: /* TR */
>> + stellaris_enet_send(s);
>> + break;
>
> Shouldn't that be something like:
>
> if (value & 1) {
> stellaris_enet_send(s);
> }
Yep.
-- PMM
- [Qemu-devel] [PATCH 0/5] stellaris_enet: overhaul TX handling, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH 5/5] hw/net/stellaris_enet: Fix debug format strings, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH 4/5] hw/net/stellaris_enet: Correctly implement the TR and THR registers, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH 2/5] hw/net/stellaris_enet: Correct handling of packet padding, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH 1/5] hw/net/stellaris_enet: Restructure tx_fifo code to avoid buffer overrun, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH 3/5] hw/net/stellaris_enet: Rewrite tx fifo handling code, Peter Maydell, 2014/04/01