[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] hw/net/stellaris_enet: Fix debug format str
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] hw/net/stellaris_enet: Fix debug format strings |
Date: |
Tue, 1 Apr 2014 18:47:35 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
* Peter Maydell (address@hidden) wrote:
> Fix various debug format strings which were incorrect for the
> data type, so that building with debug enabled is possible.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> hw/net/stellaris_enet.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c
> index 0210108..db20b05 100644
> --- a/hw/net/stellaris_enet.c
> +++ b/hw/net/stellaris_enet.c
> @@ -161,7 +161,7 @@ static ssize_t stellaris_enet_receive(NetClientState *nc,
> const uint8_t *buf, si
> return -1;
> }
>
> - DPRINTF("Received packet len=%d\n", size);
> + DPRINTF("Received packet len=%zu\n", size);
> n = s->next_packet + s->np;
> if (n >= 31)
> n -= 31;
> @@ -276,7 +276,7 @@ static void stellaris_enet_write(void *opaque, hwaddr
> offset,
> switch (offset) {
> case 0x00: /* IACK */
> s->ris &= ~value;
> - DPRINTF("IRQ ack %02x/%02x\n", value, s->ris);
> + DPRINTF("IRQ ack %02" PRIx64 "/%02x\n", value, s->ris);
> stellaris_enet_update(s);
> /* Clearing TXER also resets the TX fifo. */
> if (value & SE_INT_TXER) {
> @@ -284,7 +284,7 @@ static void stellaris_enet_write(void *opaque, hwaddr
> offset,
> }
> break;
> case 0x04: /* IM */
> - DPRINTF("IRQ mask %02x/%02x\n", value, s->ris);
> + DPRINTF("IRQ mask %02" PRIx64 "/%02x\n", value, s->ris);
> s->im = value;
> stellaris_enet_update(s);
> break;
> --
> 1.9.0
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 0/5] stellaris_enet: overhaul TX handling, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH 5/5] hw/net/stellaris_enet: Fix debug format strings, Peter Maydell, 2014/04/01
- Re: [Qemu-devel] [PATCH 5/5] hw/net/stellaris_enet: Fix debug format strings,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH 4/5] hw/net/stellaris_enet: Correctly implement the TR and THR registers, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH 2/5] hw/net/stellaris_enet: Correct handling of packet padding, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH 1/5] hw/net/stellaris_enet: Restructure tx_fifo code to avoid buffer overrun, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH 3/5] hw/net/stellaris_enet: Rewrite tx fifo handling code, Peter Maydell, 2014/04/01