[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on

From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines
Date: Sun, 23 Mar 2014 14:32:15 +0200

On Fri, 2014-03-21 at 00:16 +0100, Paolo Bonzini wrote:
> Il 20/03/2014 23:33, Marcel Apfelbaum ha scritto:
> > I've seen something like that somewhere, but I didn't quite like it.
> > I was looking for something more elegant as I was *almost* sure
> > this kind of solution will not pass the reviews :)
> >
> > But maybe I'll try this, let's see what happens,
> If all you're looking for is bigendian (disabling iasl disassembly on 
> bigendian makes sense), your patch v2 is fine.

Thanks Paolo, I thought so too, but Michael NACKED it having a valid point:
We should check this at configure time... .

Anyway, if only iasl dis-assembler has issues, this can be seen as acpi test's
problem and handled inside the test.

> Assembling ASL on bigendian is supported by at least Fedora and Debian 
> (and hence Ubuntu).
> Paolo

reply via email to

[Prev in Thread] Current Thread [Next in Thread]