Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines

[Marcel Apfelbaum]

On Sun, 2014-03-23 at 12:14 +0000, Peter Maydell wrote:
> On 23 March 2014 09:49, Michael S. Tsirkin <address@hidden> wrote:
> > At this point I'm confused.
> > If iasl compiler is broken, we should detect and fix that.
> > It might be ok to just detect endian-ness as a quick work-around.
> > BTW configure already has code to detect endian-ness:
> > if test "$bigendian" = "yes" ; then
> >   echo "HOST_WORDS_BIGENDIAN=y" >> $config_host_mak
> > fi
> 
> That's the endianness of the machine we're compiling QEMU
> for, not the endianness of the machine we're compiling QEMU
> on. If for instance you're on x86_64 cross-compiling for PPC
> then HOST_WORDS_BIGENDIAN is true, but the iasl you use
> in the build process will be running on a little endian machine.

Hi Peter, are you sure about this?
I saw the 'target_bigendian' that does what you described above.
$bigendian is the result of a little C program that checks *host's* endian-ness.
Of course I might have missed something.

By the way, considering what Paolo said that the iasl compiler does work
for BE machines (the dis-assembler has the problem), leads me to see this issue
as the test's problem.
So I am going to leave the 'configure' with no modifications
and check inside the test itself that the expected files can be disassembled.

Thanks,
Marcel


> 
> thanks
> -- PMM