[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 10/21] target-arm: Add v8 mmu translation sup
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4 10/21] target-arm: Add v8 mmu translation support |
Date: |
Thu, 20 Mar 2014 18:20:13 +0000 |
On 6 March 2014 19:32, Peter Maydell <address@hidden> wrote:
> @@ -1065,8 +1065,9 @@ static void par_write(CPUARMState *env, const
> ARMCPRegInfo *ri, uint64_t value)
> */
> static inline bool extended_addresses_enabled(CPUARMState *env)
> {
> - return arm_feature(env, ARM_FEATURE_LPAE)
> - && (env->cp15.c2_control & (1U << 31));
> + return arm_feature(env, ARM_FEATURE_V8)
> + || (arm_feature(env, ARM_FEATURE_LPAE)
> + && (env->cp15.c2_control & (1U << 31)));
> }
Just noticed a minor nit here -- rather than checking
for ARM_FEATURE_V8 we should be using arm_el_is_aa64(env, 1)
(as the translation code itself does). At the moment the
two give the same answer, but if/when we ever support
running a 32 bit kernel on an ARMv8 CPU they'll be
different, so better to get the check right to start with.
I'll fix this for the next round of these patches
(and also update the now out of date comment).
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v4 16/21] target-arm: Implement SP_EL0, SP_EL1, (continued)
- [Qemu-devel] [PATCH v4 19/21] target-arm: Implement AArch64 EL1 exception handling, Peter Maydell, 2014/03/06
- [Qemu-devel] [PATCH v4 18/21] target-arm: Move arm_log_exception() into internals.h, Peter Maydell, 2014/03/06
- [Qemu-devel] [PATCH v4 21/21] hw/arm/virt: Add support for Cortex-A57, Peter Maydell, 2014/03/06
- [Qemu-devel] [PATCH v4 04/21] target-arm: Provide correct syndrome information for cpreg access traps, Peter Maydell, 2014/03/06
- [Qemu-devel] [PATCH v4 10/21] target-arm: Add v8 mmu translation support, Peter Maydell, 2014/03/06
- Re: [Qemu-devel] [PATCH v4 10/21] target-arm: Add v8 mmu translation support,
Peter Maydell <=
- [Qemu-devel] [PATCH v4 11/21] target-arm: Don't mention PMU in debug feature register, Peter Maydell, 2014/03/06
- [Qemu-devel] [PATCH v4 06/21] target-arm: Provide syndrome information for MMU faults, Peter Maydell, 2014/03/06
[Qemu-devel] [PATCH v4 14/21] target-arm: Implement AArch64 views of fault status and data registers, Peter Maydell, 2014/03/06