[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 21/21] hw/arm/virt: Add support for Cortex-A5
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH v4 21/21] hw/arm/virt: Add support for Cortex-A57 |
Date: |
Mon, 17 Mar 2014 17:12:14 +1000 |
On Fri, Mar 7, 2014 at 5:33 AM, Peter Maydell <address@hidden> wrote:
> Support the Cortex-A57 in the virt machine model.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> This should perhaps not be just stealing the a15mpcore_priv
> on the basis that it's a GICv2...
Wont this mean you gets lots of extraneous hardware? Although, with a
pure virtual machine I guess you can do whatever you really want.
> ---
> hw/arm/virt.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 517f2fe..d985d2e 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -123,6 +123,14 @@ static VirtBoardInfo machines[] = {
> .irqmap = a15irqmap,
> },
> {
> + .cpu_model = "cortex-a57",
> + /* Use the A15 private peripheral model for now: probably wrong! */
> + .qdevname = "a15mpcore_priv",
Can you just change this to gics qdev name? The qdev propnames of gic
and mpcore ("num-cpu" and "num-irq") should just match. Then perhaps a
little callback to set gicv2 version property.
Regards,
Peter
> + .gic_compatible = "arm,cortex-a15-gic",
> + .memmap = a15memmap,
> + .irqmap = a15irqmap,
> + },
> + {
> .cpu_model = "host",
> /* We use the A15 private peripheral model to get a V2 GIC */
> .qdevname = "a15mpcore_priv",
> --
> 1.9.0
>
>
- [Qemu-devel] [PATCH v4 09/21] target-arm: Fix VFP enables for AArch32 EL0 under AArch64 EL1, (continued)
- [Qemu-devel] [PATCH v4 09/21] target-arm: Fix VFP enables for AArch32 EL0 under AArch64 EL1, Peter Maydell, 2014/03/06
- [Qemu-devel] [PATCH v4 17/21] target-arm: Implement AArch64 SPSR_EL1, Peter Maydell, 2014/03/06
- [Qemu-devel] [PATCH v4 16/21] target-arm: Implement SP_EL0, SP_EL1, Peter Maydell, 2014/03/06
- [Qemu-devel] [PATCH v4 19/21] target-arm: Implement AArch64 EL1 exception handling, Peter Maydell, 2014/03/06
- [Qemu-devel] [PATCH v4 18/21] target-arm: Move arm_log_exception() into internals.h, Peter Maydell, 2014/03/06
- [Qemu-devel] [PATCH v4 21/21] hw/arm/virt: Add support for Cortex-A57, Peter Maydell, 2014/03/06
- Re: [Qemu-devel] [PATCH v4 21/21] hw/arm/virt: Add support for Cortex-A57,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH v4 04/21] target-arm: Provide correct syndrome information for cpreg access traps, Peter Maydell, 2014/03/06
- [Qemu-devel] [PATCH v4 10/21] target-arm: Add v8 mmu translation support, Peter Maydell, 2014/03/06
- [Qemu-devel] [PATCH v4 11/21] target-arm: Don't mention PMU in debug feature register, Peter Maydell, 2014/03/06
- [Qemu-devel] [PATCH v4 06/21] target-arm: Provide syndrome information for MMU faults, Peter Maydell, 2014/03/06