[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Makefile: Don't find and delete when $(DSOSUF)

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] Makefile: Don't find and delete when $(DSOSUF) is empty in "make clean"
Date: Tue, 18 Mar 2014 10:19:06 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Peter Maydell <address@hidden> writes:

> On 17 March 2014 18:51, Andreas Färber <address@hidden> wrote:
>> Am 17.03.2014 09:30, schrieb Markus Armbruster:
>>> Stefan Weil <address@hidden> writes:
>>>> Am 14.03.2014 09:38, schrieb Fam Zheng:
>>>>> DANGEROUS: don't try it before you read to the end.
>>>>> A first "make distclean" will unset $(DSOSUF), a following "make
>>>>> distclean" or "make clean" will find all the files and delete it.
>>>>> Including all the files in the .git directory!
>>>> If you only use out-of-tree build, you are safe here. Maybe we should no
>>>> longer support in-tree builds. Personally, I nearly never use them.
>>> Same here.  Building in-tree is calling for trouble.  I'd support a
>>> patch that prevents it.
>> What about disabling it only when .git/ is available?
> The other idea that's been suggested in the past is to
> have the makefile/configure simply map attempts to build
> in-tree into 'create builddir and build in it'. This
> is probably easier to suggest than to get right in all
> situations :-)

Perfect is the enemy of good enough.


%: force
        @$(MAKE) -C bld $@
force: ;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]