[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Makefile: Don't find and delete when $(DSOSUF)

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] Makefile: Don't find and delete when $(DSOSUF) is empty in "make clean"
Date: Tue, 18 Mar 2014 09:24:09 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Andreas Färber <address@hidden> writes:

> Am 17.03.2014 09:30, schrieb Markus Armbruster:
>> Stefan Weil <address@hidden> writes:
>>> Am 14.03.2014 09:38, schrieb Fam Zheng:
>>>> DANGEROUS: don't try it before you read to the end.
>>>> A first "make distclean" will unset $(DSOSUF), a following "make
>>>> distclean" or "make clean" will find all the files and delete it.
>>>> Including all the files in the .git directory!
>>> If you only use out-of-tree build, you are safe here. Maybe we should no
>>> longer support in-tree builds. Personally, I nearly never use them.
>> Same here.  Building in-tree is calling for trouble.  I'd support a
>> patch that prevents it.
> What about disabling it only when .git/ is available? There seems
> nothing wrong with doing one-time builds inside an extracted tarball on
> central build servers;

Except for this one: in-tree build will rot even faster.

>                        most of the problems arise when building inside
> the developer's git checkout.
> If we do drop support for building in-tree (always or with Git), we
> could also drop most of the .gitignore clutter. :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]