[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support f
From: |
James Hogan |
Subject: |
Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS |
Date: |
Fri, 14 Mar 2014 09:42:11 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
Hi Andreas,
On 13/03/14 21:28, Andreas Färber wrote:
>> diff --git a/target-mips/kvm.c b/target-mips/kvm.c
>> new file mode 100644
>> index 0000000..0ec343d
>> --- /dev/null
>> +++ b/target-mips/kvm.c
> [...]
>> +static inline int kvm_mips_put_one_reg(CPUState *cs, int reg_id, int32
>> *addr)
>
> Did you mean int32_t?
>> +static inline int kvm_mips_get_one_reg(CPUState *cs, int reg_id, int32
>> *addr)
>
> int32_t?
>> + *addr = (int32)val64;
>
> int32_t?
> int32 is a type used in softfloat that has weird at-least-as-wide
> semantics and bit us in the past.
Well spotted, they should indeed be int32_t.
> Otherwise looking good now, thanks for the CPU cleanups! We just had
> another round of CPU refactorings go in today, but I don't spot a
> conflict in this patch. Please rebase your local branch to verify.
It rebased clearly, but I'll double check and send a v4 today anyway.
Thanks
James
- [Qemu-devel] [PATCH v3 5/9] kvm: Allow arch to set sigmask length, (continued)
- [Qemu-devel] [PATCH v3 5/9] kvm: Allow arch to set sigmask length, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 7/9] hw/mips: In KVM mode, inject IRQ2 (I/O) interupts via ioctls, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 2/9] hw/mips: Add API to convert KVM guest KSEG0 <-> GPA, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 3/9] target-mips: get_physical_address: Add defines for segment bases, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 9/9] target-mips: Enable KVM support in build system, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 8/9] hw/mips: malta: Add KVM support, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 4/9] target-mips: get_physical_address: Add KVM awareness, James Hogan, 2014/03/06