[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support f
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS |
Date: |
Thu, 13 Mar 2014 22:35:58 +0000 |
On 13 March 2014 21:28, Andreas Färber <address@hidden> wrote:
> int32 is a type used in softfloat that has weird at-least-as-wide
> semantics and bit us in the past.
I'm coming round to the opinion that we should just change all
those to int32_t &c. I know we had a discussion about efficiency
at one point and I was on the other side at that time, but I
don't really think it matters much either way and having the
types still lurking around is just confusing. Maybe after 2.0
(and we should nuke the STATUS macros too).
Either way, int32 shouldn't be used outside the softfloat code
and its callers.
> I'm not sure if we have a policy about __u64 etc. in KVM code. Since
> it'll be Linux-only I don't see problems currently; for cross-platform
> parts we prefer uint64_t. Suggest to leave as is unless told otherwise.
For ARM I took the view that __u64 were the kernel's types, not
ours. The kernel header structs define fields as __u64 but for
in-QEMU functions and variables we should use the posix uint64_t.
thanks
-- PMM
- [Qemu-devel] [PATCH v3 0/9] KVM Support for MIPS32 Processors, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 1/9] hw/mips/cputimer: Don't start periodic timer in KVM mode, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 5/9] kvm: Allow arch to set sigmask length, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 7/9] hw/mips: In KVM mode, inject IRQ2 (I/O) interupts via ioctls, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 2/9] hw/mips: Add API to convert KVM guest KSEG0 <-> GPA, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 3/9] target-mips: get_physical_address: Add defines for segment bases, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 9/9] target-mips: Enable KVM support in build system, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 8/9] hw/mips: malta: Add KVM support, James Hogan, 2014/03/06
- [Qemu-devel] [PATCH v3 4/9] target-mips: get_physical_address: Add KVM awareness, James Hogan, 2014/03/06