[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] libqtest: Avoid inline varargs functions
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH] libqtest: Avoid inline varargs functions |
|
Date: |
Thu, 13 Mar 2014 13:31:43 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 13.03.2014 12:31, schrieb Peter Maydell:
> Older versions of gcc (eg 4.6) can't handle varargs functions declared
> inline for anything other than completely trivial uses, and complain:
>
> tests/qom-test.c: In function 'qmp': tests/libqtest.h:359:60: sorry,
> unimplemented: function 'qmp' can never be inlined because it uses
> variable argument lists
>
> Avoid this problem by putting the functions into libqtest.c instead
> of using inline definitions in libqtest.h.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Feel free to go ahead with this.
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg