[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] libqtest: Avoid inline varargs functions

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] libqtest: Avoid inline varargs functions
Date: Thu, 13 Mar 2014 12:35:49 +0000

On 13 March 2014 12:31, Andreas Färber <address@hidden> wrote:
> Am 13.03.2014 12:31, schrieb Peter Maydell:
>> Older versions of gcc (eg 4.6) can't handle varargs functions declared
>> inline for anything other than completely trivial uses, and complain:
>> tests/qom-test.c: In function 'qmp': tests/libqtest.h:359:60: sorry,
>> unimplemented: function 'qmp' can never be inlined because it uses
>> variable argument lists
>> Avoid this problem by putting the functions into libqtest.c instead
>> of using inline definitions in libqtest.h.
>> Signed-off-by: Peter Maydell <address@hidden>
> Reviewed-by: Andreas Färber <address@hidden>
> Feel free to go ahead with this.

Applied to master, thanks. Your pullreq is next in the queue.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]