[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 7/9] acpi: consume CPU hotplug IO resource in PNP0
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [RFC 7/9] acpi: consume CPU hotplug IO resource in PNP0C02 device |
Date: |
Sun, 16 Feb 2014 17:39:44 +0200 |
On Fri, Feb 07, 2014 at 01:51:34PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> hw/i386/acpi-build.c | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index ce5f715..5cd0c80 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -70,6 +70,8 @@ typedef struct AcpiPmInfo {
> uint32_t gpe0_blk;
> uint32_t gpe0_blk_len;
> uint32_t io_base;
> + uint16_t cpuhp_io_base;
> + uint16_t cpuhp_io_len;
> } AcpiPmInfo;
>
> typedef struct AcpiMiscInfo {
> @@ -141,11 +143,14 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
> Object *obj = NULL;
> QObject *o;
>
> + pm->cpuhp_io_len = ACPI_GPE_PROC_LEN;
> if (piix) {
> obj = piix;
> + pm->cpuhp_io_base = PIIX4_CPU_HOTPLUG_IO_BASE;
> }
> if (lpc) {
> obj = lpc;
> + pm->cpuhp_io_base = ICH9_CPU_HOTPLUG_IO_BASE;
> }
> assert(obj);
>
Not a must but would be nicer to get these as
device properties.
If we change this, cpuhp_io_len can be used directly ...
> @@ -1145,6 +1150,11 @@ build_ssdt(GArray *table_data, GArray *linker,
> pm->gpe0_blk, /* _MAX */
> 0x0, /* _ALN */
> pm->gpe0_blk_len); /* _LEN */
> + ACPI_IO(RESBUF, Decode16,
> + pm->cpuhp_io_base, /* _MIN */
> + pm->cpuhp_io_base, /* _MAX */
> + 0x0, /* _ALN */
> + pm->cpuhp_io_len); /* _LEN */
> );
> );
> );
> --
> 1.7.1
- [Qemu-devel] [RFC 1/9] Revert "pc: Q35 DSDT: exclude CPU hotplug IO range from PCI bus resources", (continued)
- [Qemu-devel] [RFC 1/9] Revert "pc: Q35 DSDT: exclude CPU hotplug IO range from PCI bus resources", Igor Mammedov, 2014/02/07
- [Qemu-devel] [RFC 2/9] Revert "pc: PIIX DSDT: exclude CPU/PCI hotplug & GPE0 IO range from PCI bus resources", Igor Mammedov, 2014/02/07
- [Qemu-devel] [RFC 3/9] Partial revert "pc: ACPI: expose PRST IO range via _CRS", Igor Mammedov, 2014/02/07
- [Qemu-devel] [RFC 4/9] acpi: replace opencoded opcodes with defines, Igor Mammedov, 2014/02/07
- [Qemu-devel] [RFC 5/9] acpi: add PNP0C02 to PCI0 bus, Igor Mammedov, 2014/02/07
- [Qemu-devel] [RFC 6/9] acpi: consume GPE0 IO resources in PNP0C02 device, Igor Mammedov, 2014/02/07
- [Qemu-devel] [RFC 7/9] acpi: consume CPU hotplug IO resource in PNP0C02 device, Igor Mammedov, 2014/02/07
- Re: [Qemu-devel] [RFC 7/9] acpi: consume CPU hotplug IO resource in PNP0C02 device,
Michael S. Tsirkin <=
- [Qemu-devel] [RFC 8/9] pcihp: expose PCI hotplug MMIO base/length as properties of piix4pm, Igor Mammedov, 2014/02/07
- [Qemu-devel] [RFC 9/9] acpi: consume PCIHP IO resource in PNP0C02 device, Igor Mammedov, 2014/02/07
- Re: [Qemu-devel] [RFC 0/9] generate dynamic _CRS for motherboard resources, Michael S. Tsirkin, 2014/02/16
- Re: [Qemu-devel] [RFC 0/9] generate dynamic _CRS for motherboard resources, Igor Mammedov, 2014/02/18
- Re: [Qemu-devel] [RFC 0/9] generate dynamic _CRS for motherboard resources, Laszlo Ersek, 2014/02/18