[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st un
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm |
Date: |
Fri, 20 Dec 2013 16:08:10 +0000 |
On 19 December 2013 17:46, Richard Henderson <address@hidden> wrote:
> On 12/17/2013 07:12 AM, Peter Maydell wrote:
>> + if (size == 3 && opc == 2) {
>> + /* PRFM - prefetch */
>> + return;
>> + }
>> + if (opc == 3 && size > 1) {
>> + unallocated_encoding(s);
>> + return;
>> + }
>> + is_store = (opc == 0);
>> + is_signed = opc & (1<<1);
>> + is_extended = (size < 3) && (opc & 1);
>
> I thought we'd discussed rearranging this bit of decoding to better match the
> ARM?
Can't find anything in my email archive but I wouldn't be surprised
if I was just searching on the wrong keywords...
> In particular, opc = 2 && size = 2 should be unallocated.
This is LDRSW (immediate), not unallocated, isn't it?
I agree the decode logic isn't laid out the same as the ARM ARM,
but I'm pretty sure it's correct.
> And please no (1<<1).
Agreed.
-- PMM
- Re: [Qemu-devel] [PATCH 07/21] target-arm: A64: add support for 3 src data proc insns, (continued)
[Qemu-devel] [PATCH 18/21] target-arm: aarch64: add support for ld lit, Peter Maydell, 2013/12/17
[Qemu-devel] [PATCH 14/21] target-arm: A64: Implement minimal set of EL0-visible sysregs, Peter Maydell, 2013/12/17
[Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Peter Maydell, 2013/12/17
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Richard Henderson, 2013/12/19
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Richard Henderson, 2013/12/20
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Peter Maydell, 2013/12/20
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Richard Henderson, 2013/12/20
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Peter Maydell, 2013/12/20
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Richard Henderson, 2013/12/20
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Peter Maydell, 2013/12/20
[Qemu-devel] [PATCH 10/21] target-arm: A64: implement FMOV, Peter Maydell, 2013/12/17
[Qemu-devel] [PATCH 19/21] target-arm: Widen exclusive-access support struct fields to 64 bits, Peter Maydell, 2013/12/17
[Qemu-devel] [PATCH 21/21] default-configs: Add config for aarch64-linux-user, Peter Maydell, 2013/12/17