Re: [Qemu-devel] [PATCH] roms: Flush icache when writing roms to guest memory

[Alexander Graf]

On 11.12.2013, at 14:27, Paolo Bonzini <address@hidden> wrote:

> Il 11/12/2013 14:23, Alexander Graf ha scritto:
>> +            if (kvm_enabled()) {
>> +                /*
>> +                 * The guest may want to directly execute from the rom 
>> region,
>> +                 * so we better invalidate its icache
>> +                 */
>> +                flush_icache_range((uintptr_t)ptr, (uintptr_t)ptr + l);
>> +            }
> 
> Shouldn't KVM itself do that when a memslot is registered?  There should
> be no reason for non-TCG QEMU to flush the icache.

How would KVM know when things changed inside of a memory region? It's up to 
user space to manage the contents of a memory region, no?

Alex