[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] config-host.mak: escape configure arguments
From: |
Gabriel Kerneis |
Subject: |
Re: [Qemu-devel] [PATCH] config-host.mak: escape configure arguments |
Date: |
Sat, 5 Oct 2013 23:18:21 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Oct 06, 2013 at 12:54:08AM +0900, Peter Maydell wrote:
> So this sed script appears to convert literal newlines in the input
> Is that what's intended?
Yes.
> It doesn't seem very useful because if you cut-n-paste (or pipe)
> 'hello\nworld' into a shell you get an actual backslash-n, not a newline.
You're right. Then the best is probably to expect that ./configure parameters
will not get any litteral newline (and remove the sed call doing the
substitution in my patch). Or detect them (with grep) and print an error?
Litteral newlines break badly config-host.mak anyway.
--
Gabriel