Re: [Qemu-devel] [PATCH] config-host.mak: escape configure arguments

[Stefan Weil]

Am 06.10.2013 00:18, schrieb Gabriel Kerneis:
> On Sun, Oct 06, 2013 at 12:54:08AM +0900, Peter Maydell wrote:
>> So this sed script appears to convert literal newlines in the input
>> Is that what's intended?
> Yes.
>
>> It doesn't seem very useful because if you cut-n-paste (or pipe)
>> 'hello\nworld' into a shell you get an actual backslash-n, not a newline.
> You're right.  Then the best is probably to expect that ./configure parameters
> will not get any litteral newline (and remove the sed call doing the
> substitution in my patch).  Or detect them (with grep) and print an error?
> Litteral newlines break badly config-host.mak anyway.
>


What about removing the comment with the configure parameters
from config-host.mak? Instead of that comment, we could write a
new file config.status as a script (executable) which can be called
to repeat the latest configuration.

This would have several benefits:

* Having the latest configuration in config.status is very common (GNU
autoconf).

* Easier code - no need to create a configure call from a comment.

* Users can call config.status if they want to repeat the configure process.

Regards,
Stefan