[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: use correct filename for error report
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] block: use correct filename for error report |
Date: |
Wed, 2 Oct 2013 11:48:44 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Sep 24, 2013 at 06:14:01PM +0800, Dunrong Huang wrote:
> The content filename point to will be erased by qemu_opts_absorb_qdict()
> in raw_open_common() in drv->bdrv_file_open()
>
> So it's better to use bs->filename.
>
> Signed-off-by: Dunrong Huang <address@hidden>
> ---
> block.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
The same issue affects the rest of the function:
#ifndef _WIN32
if (bs->is_temporary) {
assert(filename != NULL);
unlink(filename);
}
#endif
Do you want to send a separate patch to fix this?
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
- Re: [Qemu-devel] [PATCH] block: use correct filename for error report,
Stefan Hajnoczi <=