Re: [Qemu-devel] [PATCH] block: use correct filename for error report

[Dunrong Huang]

On Wed, Oct 2, 2013 at 5:48 PM, Stefan Hajnoczi <address@hidden> wrote:

On Tue, Sep 24, 2013 at 06:14:01PM +0800, Dunrong Huang wrote:
> The content filename point to will be erased by qemu_opts_absorb_qdict()
> in raw_open_common() in drv->bdrv_file_open()
>
> So it's better to use bs->filename.
>
> Signed-off-by: Dunrong Huang <address@hidden>
> ---
>  block.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

The same issue affects the rest of the function:

#ifndef _WIN32
    if (bs->is_temporary) {
        assert(filename != NULL);
        unlink(filename);
    }
#endif

Do you want to send a separate patch to fix this?

Sure. 

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

--

Best Regards,

Dunrong Huang 

Homepage: http://mathslinux.org