[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 30/60] AArch64: Add extr instruction emulation
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 30/60] AArch64: Add extr instruction emulation |
Date: |
Fri, 27 Sep 2013 12:45:20 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/26/2013 05:48 PM, Alexander Graf wrote:
> + if (is_32bit) {
> + tcg_gen_ext32u_i64(tcg_tmp, cpu_reg(rm));
> + } else {
> + tcg_gen_mov_i64(tcg_tmp, cpu_reg(rm));
> + }
> + tcg_gen_shri_i64(tcg_res, cpu_reg(rm), imms);
> + tcg_gen_shli_i64(tcg_tmp, cpu_reg(rn), bitsize - imms);
> + tcg_gen_or_i64(cpu_reg(rd), tcg_tmp, tcg_res);
The first ext/mov is incorrectly unused. This will
produce incorrect results for is_32bit.
r~
- [Qemu-devel] [PATCH 18/60] AArch64: Add umov instruction emulation, (continued)
- [Qemu-devel] [PATCH 18/60] AArch64: Add umov instruction emulation, Alexander Graf, 2013/09/26
- [Qemu-devel] [PATCH 03/60] arm: Split VFP cmp from FPSCR setting, Alexander Graf, 2013/09/26
- [Qemu-devel] [PATCH 28/60] AArch64: Add movi instruction emulation, Alexander Graf, 2013/09/26
- [Qemu-devel] [PATCH 16/60] AArch64: Add emulation for SIMD ld/st multiple, Alexander Graf, 2013/09/26
- [Qemu-devel] [PATCH 27/60] AArch64: Add addi instruction emulation, Alexander Graf, 2013/09/26
- [Qemu-devel] [PATCH 25/60] AArch64: Add SIMD shl instruction emulation, Alexander Graf, 2013/09/26
- [Qemu-devel] [PATCH 30/60] AArch64: Add extr instruction emulation, Alexander Graf, 2013/09/26
- Re: [Qemu-devel] [PATCH 30/60] AArch64: Add extr instruction emulation,
Richard Henderson <=
- [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation, Alexander Graf, 2013/09/26
- [Qemu-devel] [PATCH 23/60] AArch64: Add AdvSIMD modified immediate group handling, Alexander Graf, 2013/09/26
- [Qemu-devel] [PATCH 31/60] AArch64: Add bfm family instruction emulation, Alexander Graf, 2013/09/26
- [Qemu-devel] [PATCH 32/60] AArch64: Add svc instruction emulation, Alexander Graf, 2013/09/26
- [Qemu-devel] [PATCH 35/60] AArch64: Add mrs instruction emulation, Alexander Graf, 2013/09/26
- [Qemu-devel] [PATCH 33/60] AArch64: Add bc instruction emulation, Alexander Graf, 2013/09/26
- [Qemu-devel] [PATCH 38/60] AArch64: Add stub barrier instruction emulation, Alexander Graf, 2013/09/26
- [Qemu-devel] [PATCH 21/60] AArch64: Convert SIMD load/store to common function, Alexander Graf, 2013/09/26