[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 10/20] iscsi: set limits in BlockDriverState
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCHv2 10/20] iscsi: set limits in BlockDriverState |
Date: |
Thu, 19 Sep 2013 14:14:08 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/17/2013 07:48 AM, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> block/iscsi.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index aabcddb..21b1ecf 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1362,6 +1362,16 @@ static int iscsi_open(BlockDriverState *bs, QDict
> *options, int flags)
> sizeof(struct scsi_inquiry_block_limits));
> scsi_free_scsi_task(task);
> task = NULL;
> +
> + if (iscsilun->bl.max_unmap < 0xffffffff) {
> + bs->max_discard = sector_lun2qemu(iscsilun->bl.max_unmap,
> iscsilun);
> + }
> + bs->discard_alignment = sector_lun2qemu(iscsilun->bl.opt_unmap_gran,
> iscsilun);
> +
> + if (iscsilun->bl.max_ws_len < 0xffffffff) {
> + bs->max_write_zeroes = sector_lun2qemu(iscsilun->bl.max_ws_len,
> iscsilun);
> + }
> + bs->write_zeroes_alignment =
> sector_lun2qemu(iscsilun->bl.opt_unmap_gran, iscsilun);
> }
>
> #if defined(LIBISCSI_FEATURE_NOP_COUNTER)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCHv2 03/20] block: introduce BDRV_REQ_MAY_UNMAP request flag, (continued)
- [Qemu-devel] [PATCHv2 03/20] block: introduce BDRV_REQ_MAY_UNMAP request flag, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 04/20] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 06/20] block: add discard and write_zeroes limits and alignment to BlockDriverState, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 08/20] block: honour alignment and limit in bdrv_co_discard, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 10/20] iscsi: set limits in BlockDriverState, Peter Lieven, 2013/09/17
- Re: [Qemu-devel] [PATCHv2 10/20] iscsi: set limits in BlockDriverState,
Eric Blake <=
- [Qemu-devel] [PATCHv2 09/20] iscsi: simplify iscsi_co_discard, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 05/20] block/raw: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 11/20] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 12/20] iscsi: add bdrv_co_write_zeroes, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 07/20] block: honour alignment and limit in bdrv_co_do_write_zeroes, Peter Lieven, 2013/09/17