qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2 06/20] block: add discard and write_zeroes lim


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCHv2 06/20] block: add discard and write_zeroes limits and alignment to BlockDriverState
Date: Thu, 19 Sep 2013 12:53:16 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

On 09/17/2013 07:48 AM, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <address@hidden>
> ---
>  include/block/block_int.h |   12 ++++++++++++
>  1 file changed, 12 insertions(+)

Reviewed-by: Eric Blake <address@hidden>

> +
> +    /* optimal alignment for write zeroes requests in sectors */
> +    int64_t write_zeroes_alignment;
> +
>      /* do we need to tell the quest if we have a volatile write cache? */
>      int enable_write_cache;

Hmm, I just pointed out to Paolo that this ought to be bool.  But as it
is in the context and not your actual patch, it has no bearing on this
series, and even if that gets changed first, git's pretty good about
context-only conflict resolution.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]