[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 06/20] block: add discard and write_zeroes lim
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCHv2 06/20] block: add discard and write_zeroes limits and alignment to BlockDriverState |
Date: |
Thu, 19 Sep 2013 12:53:16 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/17/2013 07:48 AM, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> include/block/block_int.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
> +
> + /* optimal alignment for write zeroes requests in sectors */
> + int64_t write_zeroes_alignment;
> +
> /* do we need to tell the quest if we have a volatile write cache? */
> int enable_write_cache;
Hmm, I just pointed out to Paolo that this ought to be bool. But as it
is in the context and not your actual patch, it has no bearing on this
series, and even if that gets changed first, git's pretty good about
context-only conflict resolution.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCHv2 00/20] block: logical block provisioning enhancements, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 01/20] block: make BdrvRequestFlags public, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 02/20] block: add flags to bdrv_*_write_zeroes, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 03/20] block: introduce BDRV_REQ_MAY_UNMAP request flag, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 04/20] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 06/20] block: add discard and write_zeroes limits and alignment to BlockDriverState, Peter Lieven, 2013/09/17
- Re: [Qemu-devel] [PATCHv2 06/20] block: add discard and write_zeroes limits and alignment to BlockDriverState,
Eric Blake <=
- [Qemu-devel] [PATCHv2 08/20] block: honour alignment and limit in bdrv_co_discard, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 10/20] iscsi: set limits in BlockDriverState, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 09/20] iscsi: simplify iscsi_co_discard, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 05/20] block/raw: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/09/17
- [Qemu-devel] [PATCHv2 11/20] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/09/17