Re: [Qemu-devel] [PATCH v1 4/4] target-arm: Add CP15 VBAR support

[Sebastian Huber]

On 2013-07-10 06:23, address@hidden wrote:
> +static int vbar_write(CPUARMState *env, const ARMCPRegInfo *ri,
> +                      uint64_t value)
> +{
> +    value &= (1 << 31);

Is the above correct?

> +    env->cp15.c12_vbar = value & ~0x1Ful;
> +    return 0;
> +}

Shouldn't this be

{
  env->cp15.c12_vbar = (uint32_t) (value & ~0x1FUL);
  return 0;
}

?

--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : address@hidden
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.