Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

[Jia Liu]

On Mon, Jul 22, 2013 at 5:43 PM, Peter Maydell <address@hidden> wrote:
> On 22 July 2013 10:42, Jia Liu <address@hidden> wrote:
>> Hi Andreas and Peter,
>>
>> On Mon, Jul 22, 2013 at 5:29 PM, Peter Maydell <address@hidden> wrote:
>>> This looks a bit odd. The commit message suggests it's an
>>> attempt to fix the bug that was fixed by commit 071b3364e --
>>> is it really needed? Andreas?

Yes! you are right, it is not needed. It was my mistake, I didn't
understand Andreas.
Thanks!

It seems I need resend a v4 with Reviewed-by Andreas&Peter.

>>
>> commit 071b3364e fix the typename only, but this one make "-cpu any"
>> "-cpu or1200" "-cpu any-or32-cpu" "-cpu or1200-or32-cpu" working fine.
>
> The last two of these would be wrong: -cpu should only
> accept CPU names, ie "any" or "or1200".
>
> -- PMM

Regards,
Jia.