[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name
Date: Mon, 22 Jul 2013 13:17:17 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7

Am 22.07.2013 12:40, schrieb Peter Maydell:
> On 22 July 2013 11:37, Andreas Färber <address@hidden> wrote:
>> Am 22.07.2013 11:43, schrieb Peter Maydell:
>>>> commit 071b3364e fix the typename only, but this one make "-cpu any"
>>>> "-cpu or1200" "-cpu any-or32-cpu" "-cpu or1200-or32-cpu" working fine.
>>> The last two of these would be wrong: -cpu should only
>>> accept CPU names, ie "any" or "or1200".
>> Peter, the story is that due to an oversight on my part, it was possible
>> to use -cpu or1200-or32-cpu only for some weeks or months. This has been
>> fixed so that only -cpu or1200 works.
> Yep; my view is that the acceptance of the -or32-cpu varieties
> was a bug which we have now fixed. In any case we should be
> consistent across target architectures about what we allow.
> I'm happy with the approach Jia has taken of just dropping
> this patch in v4 of this series.

alpha allows both, but -cpu ? just gave me a segfault. :/
It didn't have -cpu ? before QOM, so we decided to print the type names
there. Will need to investigate what's going wrong currently.

Stripping -alpha-cpu off typenames would surely be possible.


SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

reply via email to

[Prev in Thread] Current Thread [Next in Thread]