[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V7 08/13] monitor: refine parse_cmdline()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V7 08/13] monitor: refine parse_cmdline() |
Date: |
Sat, 20 Jul 2013 06:27:57 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/19/2013 07:44 PM, Wenchao Xia wrote:
> Since this function will be used by help_cmd() later, so improve
> it to make it more generic and easier to use. free_cmdline_args()
> is added to as paired function to free the result.
s/added to/added too/
>
> One change of this function is that, when the valid args in input
> exceed the limit of MAX_ARGS, it fails now, instead of return with
> MAX_ARGS of parsed args in old code. This should not impact much
> since it is rare that user input many args in monitor's "help" and
> auto complete scenario.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> monitor.c | 51 ++++++++++++++++++++++++++++++++++++++++-----------
> 1 files changed, 40 insertions(+), 11 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH V7 03/13] monitor: avoid use of global *cur_mon in block_completion_it(), (continued)
- [Qemu-devel] [PATCH V7 04/13] monitor: avoid use of global *cur_mon in monitor_find_completion(), Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 05/13] monitor: avoid use of global *cur_mon in readline_completion(), Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 06/13] monitor: avoid direct use of global variable *mon_cmds, Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 07/13] monitor: code move for parse_cmdline(), Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 08/13] monitor: refine parse_cmdline(), Wenchao Xia, 2013/07/19
- Re: [Qemu-devel] [PATCH V7 08/13] monitor: refine parse_cmdline(),
Eric Blake <=
- [Qemu-devel] [PATCH V7 09/13] monitor: support sub command in help, Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 10/13] monitor: refine monitor_find_completion(), Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 11/13] monitor: support sub command in auto completion, Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 12/13] monitor: allow "help" show message for single command in sub group, Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 13/13] monitor: improve auto complete of "help" for single command in sub group, Wenchao Xia, 2013/07/19