[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V7 08/13] monitor: refine parse_cmdline()

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH V7 08/13] monitor: refine parse_cmdline()
Date: Sat, 20 Jul 2013 06:27:57 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7

On 07/19/2013 07:44 PM, Wenchao Xia wrote:
> Since this function will be used by help_cmd() later, so improve
> it to make it more generic and easier to use. free_cmdline_args()
> is added to as paired function to free the result.

s/added to/added too/

> One change of this function is that, when the valid args in input
> exceed the limit of MAX_ARGS, it fails now, instead of return with
> MAX_ARGS of parsed args in old code. This should not impact much
> since it is rare that user input many args in monitor's "help" and
> auto complete scenario.
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  monitor.c |   51 ++++++++++++++++++++++++++++++++++++++++-----------
>  1 files changed, 40 insertions(+), 11 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]