[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V7 05/13] monitor: avoid use of global *cur_mon
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V7 05/13] monitor: avoid use of global *cur_mon in readline_completion() |
Date: |
Sat, 20 Jul 2013 06:03:03 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/19/2013 07:44 PM, Wenchao Xia wrote:
> Now all completion functions do not use *cur_mon any more, instead
> they use rs->mon. In short, structure ReadLineState decide where
> the complete action would be taken now.
>
> Tested with the case that qemu have two telnet monitors, auto
> completion function works normal.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> readline.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V7 02/13] monitor: avoid use of global *cur_mon in file_completion(), (continued)
- [Qemu-devel] [PATCH V7 02/13] monitor: avoid use of global *cur_mon in file_completion(), Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 01/13] monitor: avoid use of global *cur_mon in cmd_completion(), Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 03/13] monitor: avoid use of global *cur_mon in block_completion_it(), Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 04/13] monitor: avoid use of global *cur_mon in monitor_find_completion(), Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 05/13] monitor: avoid use of global *cur_mon in readline_completion(), Wenchao Xia, 2013/07/19
- Re: [Qemu-devel] [PATCH V7 05/13] monitor: avoid use of global *cur_mon in readline_completion(),
Eric Blake <=
- [Qemu-devel] [PATCH V7 06/13] monitor: avoid direct use of global variable *mon_cmds, Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 07/13] monitor: code move for parse_cmdline(), Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 08/13] monitor: refine parse_cmdline(), Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 09/13] monitor: support sub command in help, Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 10/13] monitor: refine monitor_find_completion(), Wenchao Xia, 2013/07/19