[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned regions |
Date: |
Tue, 16 Jul 2013 14:47:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
Il 16/07/2013 14:45, Jan Kiszka ha scritto:
> This restore the behavior prior to b018ddf633 which accidentally changed
> the return code to 0. Specifically guests probing for register existence
> were affected by this.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
> memory.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/memory.c b/memory.c
> index 757e9a5..d19b61b 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -859,7 +859,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr
> addr,
> cpu_unassigned_access(ENV_GET_CPU(cpu_single_env),
> addr, false, false, 0, size);
> }
> - return 0;
> + return -1ULL;
> }
>
> static void unassigned_mem_write(void *opaque, hwaddr addr,
>
Applied, thanks.
Paolo