Re: [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned regions

[Stefan Hajnoczi]

On Tue, Jul 16, 2013 at 02:45:16PM +0200, Jan Kiszka wrote:
> This restore the behavior prior to b018ddf633 which accidentally changed
> the return code to 0. Specifically guests probing for register existence
> were affected by this.
> 
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
>  memory.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/memory.c b/memory.c
> index 757e9a5..d19b61b 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -859,7 +859,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr 
> addr,
>          cpu_unassigned_access(ENV_GET_CPU(cpu_single_env),
>                                addr, false, false, 0, size);
>      }
> -    return 0;
> +    return -1ULL;
>  }
>  
>  static void unassigned_mem_write(void *opaque, hwaddr addr,

Fixes the IPMI timeout while booting RHEL 6.4 guests.

Tested-by: Stefan Hajnoczi <address@hidden>