[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE |
Date: |
Tue, 09 Jul 2013 23:00:58 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130704 Icedove/17.0.7 |
09.07.2013 22:37, Anthony Liguori wrote:
> Michael Tokarev <address@hidden> writes:
>
>> It looks like initially there was -nographic option to turn
>> off display, now there's another option of the same sort,
>> -display none. But code in other places of qemu checks for
>> DT_NOGRAPHIC and does not work well with -display none.
>> Make DT_NOGRAPHIC an internal version which selects DT_NONE,
>> and check for that in all other places where previously we
>> checked for DT_NOGRAPHIC.
[]
> Breaks make check:
>
> main-loop: WARNING: I/O thread spun for 1000 iterations
> **
> ERROR:/home/aliguori/git/qemu/tests/fw_cfg-test.c:63:test_fw_cfg_nographic:
> assertion failed (qfw_cfg_get_u16(fw_cfg, FW_CFG_NOGRAPHIC) == 0): (1 == 0)
> GTester: last random seed: R02S25031265f05e4d41efcf758c9ef6043b
Sure, because the test is bogus. Should I remove this bogus test?
Thanks,
/mjt
- Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE, Anthony Liguori, 2013/07/09
- Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE,
Michael Tokarev <=
- Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE, Anthony Liguori, 2013/07/09
- Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE, Peter Maydell, 2013/07/09
- Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE, Anthony Liguori, 2013/07/09
- Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE, Peter Maydell, 2013/07/09
- Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE, Anthony Liguori, 2013/07/09
- Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE, Michael Tokarev, 2013/07/16
- Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE, Michael Tokarev, 2013/07/10
- Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE, Michael Tokarev, 2013/07/10
- Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE, Peter Maydell, 2013/07/16
- Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE, Michael Tokarev, 2013/07/10