[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE
Date: Tue, 09 Jul 2013 16:24:02 -0500
User-agent: Notmuch/0.15.2+202~g0c4b8aa (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu)

Peter Maydell <address@hidden> writes:

> On 9 July 2013 21:45, Anthony Liguori <address@hidden> wrote:
>> Michael Tokarev <address@hidden> writes:
>>> 09.07.2013 22:37, Anthony Liguori wrote:
>>>> ERROR:/home/aliguori/git/qemu/tests/fw_cfg-test.c:63:test_fw_cfg_nographic:
>>>>  assertion failed (qfw_cfg_get_u16(fw_cfg, FW_CFG_NOGRAPHIC) == 0): (1 == 
>>>> 0)
>>>> GTester: last random seed: R02S25031265f05e4d41efcf758c9ef6043b
>>> Sure, because the test is bogus.
>> No, it's a guest ABI.  You cannot change the guest ABI.
> Why the heck are we telling the guest that the user
> specified -nographic anyhow? It's a dumb guest ABI...

I believe OpenBIOS uses this to determine if it should display messages
on serial or on the graphic display.

It's actually a useful ABI in that regard.


Anthony Liguori

>> -display none != -nographic.
>> nographic gives you -display none plus a stdio serial port (with muxing
>> magic).
>> -display none should not imply stdio serial port.  The vc goes to a
>> dummy display.  That's a major semantic difference.
> None of these semantics have changed AFAICT.
> -- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]