[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6] add timestamp to error_report()

From: Laszlo Ersek
Subject: Re: [Qemu-devel] [PATCH v6] add timestamp to error_report()
Date: Tue, 09 Jul 2013 09:42:11 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130621 Thunderbird/17.0.7

On 07/08/13 21:00, Luiz Capitulino wrote:
> On Mon, 8 Jul 2013 18:47:24 +0000
> Seiji Aguchi <address@hidden> wrote:
>>>> +DEF("msg", HAS_ARG, QEMU_OPTION_msg,
>>>> +    "-msg timestamp[=on|off]\n"
>>>> +    "                change the format of messages\n"
>>>> +    "                on|off controls leading timestamps (default:on)\n",
>>> Did you really intend to say it's on by default? Because it's actually
>>> disabled by default. I prefer having this disabled btw, and I can fix it
>>> myself before applying if that's what you intended.
>> My default  is "-msg timestamp".
>> Why do you think it is actually disabled by default?
> Oh, for some reason I assumed you wanted the timestamps to show up
> even when -msg is not passed. But now I see that it's on by default
> only if -msg timestamp is passed. Seems reasonable.

Yeah the "(default: XXX)" statements in "qemu-options.hx" keep confusing
me too. They don't document the default qemu behavior (ie. with the
option absent) but the default behavior of the specific option, if given
on the command line :)

> Applied to the qmp branch, thanks.

Great, thanks!

In case you're willing to reword the commit message:

Reviewed-by: Laszlo Ersek <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]