Re: [Qemu-devel] [PATCH v6] add timestamp to error_report()

[Seiji Aguchi]

> > +DEF("msg", HAS_ARG, QEMU_OPTION_msg,
> > +    "-msg timestamp[=on|off]\n"
> > +    "                change the format of messages\n"
> > +    "                on|off controls leading timestamps (default:on)\n",
> 
> Did you really intend to say it's on by default? Because it's actually
> disabled by default. I prefer having this disabled btw, and I can fix it
> myself before applying if that's what you intended.


My default  is "-msg timestamp".
Why do you think it is actually disabled by default?


> >  /*
> >   * Print an error message to current monitor if we have one, else to 
> > stderr.
> >   * Format arguments like sprintf().  The result should not contain
> > @@ -206,6 +207,15 @@ void error_print_loc(void)
> >  void error_report(const char *fmt, ...)
> >  {
> 
> There are some errors being printed to stderr that call error_get_pretty(),
> you might want to convert them to error_report() to increase coverage. But
> you can do this as a follow up patch.

I will make a follow up patch after this patch is merged to your tree.

Seiji