[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V16 0/7] replace QEMUOptionParameter with QemuOp
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH V16 0/7] replace QEMUOptionParameter with QemuOpts parser |
Date: |
Thu, 4 Jul 2013 14:52:43 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Jun 18, 2013 at 05:31:52PM +0800, Dong Xu Wang wrote:
> These patches will replace QEMUOptionParameter with QemuOpts. Change logs
> please go to each patch's commit message.
>
> Dong Xu Wang (7):
> add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print
> avoid duplication of default value in QemuOpts
> Create four QemuOptsList related functions
> Create some QemuOpts functons
> Use QemuOpts support in block layer
> query-command-line-options outputs def_value_str
> remove QEMUOptionParameter related functions and struct
>
> block.c | 100 ++++-----
> block/cow.c | 52 ++---
> block/gluster.c | 37 ++-
> block/iscsi.c | 31 ++-
> block/qcow.c | 67 +++---
> block/qcow2.c | 199 ++++++++--------
> block/qed.c | 108 +++++----
> block/qed.h | 2 +-
> block/raw-posix.c | 59 +++--
> block/raw-win32.c | 31 +--
> block/raw.c | 30 +--
> block/rbd.c | 62 +++--
> block/sheepdog.c | 81 ++++---
> block/ssh.c | 29 ++-
> block/vdi.c | 70 +++---
> block/vmdk.c | 129 ++++++-----
> block/vpc.c | 65 +++---
> block/vvfat.c | 11 +-
> include/block/block.h | 5 +-
> include/block/block_int.h | 6 +-
> include/qemu/option.h | 56 ++---
> qapi-schema.json | 5 +-
> qemu-img.c | 65 +++---
> qmp-commands.hx | 2 +
> util/qemu-config.c | 4 +
> util/qemu-option.c | 562
> +++++++++++++++++++++-------------------------
> 26 files changed, 906 insertions(+), 962 deletions(-)
>
> --
> V15->V16:
> 1) discard double-initialization.
> 2) use pointer directly, not g_strdup.
> 3) modify query-command-line-options related code.
> V14->V15:
> 1) Only delete enum QEMUOptionParType.
eblake: You commented on the last revision. Are you happy with v16?
Stefan
- Re: [Qemu-devel] [PATCH V16 0/7] replace QEMUOptionParameter with QemuOpts parser,
Stefan Hajnoczi <=