[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install' |
Date: |
Thu, 04 Jul 2013 14:54:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 03/07/2013 18:19, Tomoki Sekiyama ha scritto:
> On 7/3/13 11:58 , "Paolo Bonzini" <address@hidden> wrote:
>
>> Il 03/07/2013 17:49, Tomoki Sekiyama ha scritto:
>>> - return ga_install_service(path, log_filepath,
>>> fixed_state_dir);
>>> + if (ga_install_vss_provider()) {
>>> + return EXIT_FAILURE;
>>> + }
>>> + if (ga_install_service(path, log_filepath,
>>> fixed_state_dir)) {
>>> + ga_uninstall_vss_provider();
>>> + return EXIT_FAILURE;
>>> + }
>>> + return 0;
>>> } else if (strcmp(service, "uninstall") == 0) {
>>> + ga_uninstall_vss_provider();
>>> return ga_uninstall_service();
>>
>> I think this shouldn't be a hard failure. Only the freeze/thaw commands
>> should fail.
>>
>> Paolo
>
> Do you mean that qemu-ga should work without qga-provider.dll etc.
> even if it is configured --with-vss-sdk ?
Yes, and I'm even wondering if we should move all VSS code to a DLL
(provider and requestor---they are very tied to each other anyway
because of hEventFrozen/hEventThaw), and have qemu-ga simply look for
qga-provider.dll dropped into the executable directory.
Then qemu-ga can look for it even if it is not configured --with-vss-sdk.
This is because the license of the SDK may be problematic for
distributions that compile qemu-ga from source. These distribution
cannot distribute the SDK, and thus they will not be able to compile and
distribute the provider DLL. Still, we should make it as easy as
possible to combine a DLL and executable from separate sources
into---for example---a single MSI.
Paolo
- [Qemu-devel] [PATCH v5 04/11] Add a script to extract VSS SDK headers on POSIX system, (continued)
- [Qemu-devel] [PATCH v5 04/11] Add a script to extract VSS SDK headers on POSIX system, Tomoki Sekiyama, 2013/07/03
- [Qemu-devel] [PATCH v5 05/11] qemu-ga: Add configure options to specify path to Windows/VSS SDK, Tomoki Sekiyama, 2013/07/03
- [Qemu-devel] [PATCH v5 02/11] Add c++ keywords to QAPI helper script, Tomoki Sekiyama, 2013/07/03
- [Qemu-devel] [PATCH v5 07/11] error: Add error_set_win32 and error_setg_win32, Tomoki Sekiyama, 2013/07/03
- [Qemu-devel] [PATCH v5 06/11] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze, Tomoki Sekiyama, 2013/07/03
- [Qemu-devel] [PATCH v5 03/11] checkpatch.pl: Check .cpp files, Tomoki Sekiyama, 2013/07/03
- [Qemu-devel] [PATCH v5 08/11] qemu-ga: Add Windows VSS requester to quiesce applications and filesystems, Tomoki Sekiyama, 2013/07/03
- [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Tomoki Sekiyama, 2013/07/03
- Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Paolo Bonzini, 2013/07/03
- Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Tomoki Sekiyama, 2013/07/03
- Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install',
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Tomoki Sekiyama, 2013/07/05
- Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Laszlo Ersek, 2013/07/08
- Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Tomoki Sekiyama, 2013/07/08
- Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Laszlo Ersek, 2013/07/08
[Qemu-devel] [PATCH v5 09/11] qemu-ga: Call Windows VSS requester in fsfreeze command handler, Tomoki Sekiyama, 2013/07/03
[Qemu-devel] [PATCH v5 11/11] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command, Tomoki Sekiyama, 2013/07/03