[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] qom: Use atomics for object refcounting
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] [PATCH] qom: Use atomics for object refcounting |
Date: |
Tue, 02 Jul 2013 11:36:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Objects can soon be referenced/dereference outside the BQL. So we need
to use atomics in object_ref/unref.
Based on patch by Liu Ping Fan.
Signed-off-by: Jan Kiszka <address@hidden>
---
qom/object.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index 803b94b..a76a30b 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -683,16 +683,15 @@ GSList *object_class_get_list(const char *implements_type,
void object_ref(Object *obj)
{
- obj->ref++;
+ __sync_fetch_and_add(&obj->ref, 1);
}
void object_unref(Object *obj)
{
g_assert(obj->ref > 0);
- obj->ref--;
/* parent always holds a reference to its children */
- if (obj->ref == 0) {
+ if (__sync_sub_and_fetch(&obj->ref, 1) == 0) {
object_finalize(obj);
}
}
--
1.7.3.4
- [Qemu-devel] [PATCH] qom: Use atomics for object refcounting,
Jan Kiszka <=
Re: [Qemu-devel] [PATCH] qom: Use atomics for object refcounting, Anthony Liguori, 2013/07/02