[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE
Date: Fri, 28 Jun 2013 14:06:51 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6

Il 28/06/2013 14:05, Michael Tokarev ha scritto:
> That's exactly why I don't think looking at -nographic here in
> serial code is wrong.  It should do the same regardless of
> -nographic - if, say, serial is redirected to stdio, it should
> always pass Ctrl+C to guest instead of killing it.  So I'm
> not really sure we should test for -display none here, either.

See the patch I just sent.

>> > It would be nice to be able to say "-nographic is equivalent to
>> > '-display none -serial stdio -disable-ctrl-c -other-things'"
>> > but I'm not sure exactly what the -other-things are or even
>> > if we can set them all on the command line specifically.
> We have some code in sun4 which also enabled serial ports
> differently with and without -nographic, maybe because of
> the same thing (which is what this all is about!).
> And there's also another place, passing this NOGRAPHIC thing
> to bios.
> So far that's all.  With chardev you can explicitly control
> Ctrl+C behavour using signal={on|off} attribute.

Unfortunately, you cannot use -chardev for the vast majority of boards
(all those that have no ISA/PCI/virtio).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]