Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

[Peter Maydell]

On 28 June 2013 13:05, Michael Tokarev <address@hidden> wrote:
> 28.06.2013 15:55, Peter Maydell wrote:
>> The point is that one of the things -nographic does, as well
>> as disabling the graphics display, is to redirect the serial
>> port (among other things) to stdio. That's why there's code
>> in the char backend that cares about "did you say -nographic":
>> because -nographic means "no graphic display, serial port on
>> terminal, send ctrl-c in terminal to guest rather than killing
>> qemu, [some other stuff]".
>
> That's exactly why I don't think looking at -nographic here in
> serial code is wrong.  It should do the same regardless of
> -nographic - if, say, serial is redirected to stdio, it should
> always pass Ctrl+C to guest instead of killing it.  So I'm
> not really sure we should test for -display none here, either.

No, I do not want "-serial stdio" to mean "and also stop
ctrl-c killing QEMU". If you want that you should have to
specify it specifically (or if you say -nographic it should
happen by the code in vl.c opening the serial backend with
the right options).

-- PMM