Re: [Qemu-devel] [PATCH 23/23] bsd-user: add arm cpu support

[Peter Maydell]

On 24 June 2013 03:03, Stacey Son <address@hidden> wrote:
> This change adds support for the arm cpu target.  In addition, it moves the
> cpu dependent code out of main.c into the individual architecture directories
> and cleans up main.c in general. Credit for much of this code: Olivier 
> Houchard.

Rule of thumb: if your commit message says "also" or "in addition"
it's a sign it should probably be more than one patch.

>  bsd-user/Makefile.objs                |    2 +-
>  bsd-user/arm/syscall.h                |   36 ++
>  bsd-user/arm/target_arch.h            |   13 +
>  bsd-user/arm/target_arch_cpu.h        |  405 +++++++++++++
>  bsd-user/arm/target_arch_signal.h     |  255 ++++++++
>  bsd-user/arm/target_arch_sigtramp.h   |   33 +
>  bsd-user/arm/target_arch_sysarch.h    |   80 +++
>  bsd-user/arm/target_arch_thread.h     |   40 ++
>  bsd-user/arm/target_arch_vmparam.h    |   49 ++
>  bsd-user/freebsd/host_os.h            |   46 ++
>  bsd-user/i386/target_arch.h           |   11 +
>  bsd-user/i386/target_arch_cpu.c       |   79 +++
>  bsd-user/i386/target_arch_cpu.h       |  290 +++++++++
>  bsd-user/i386/target_arch_signal.h    |    7 +
>  bsd-user/main.c                       | 1062 
> ++-------------------------------
>  bsd-user/mips/target_arch.h           |   13 +
>  bsd-user/mips/target_arch_cpu.h       |  227 +++++++
>  bsd-user/mips/target_arch_signal.h    |    9 +
>  bsd-user/mips64/target_arch.h         |   13 +
>  bsd-user/mips64/target_arch_cpu.h     |  226 +++++++
>  bsd-user/mips64/target_arch_signal.h  |    9 +

...in particular an "add ARM support" patch shouldn't be touching
i386, mips, sparc, etc code.

thanks
-- PMM